Wiki source code of pull-requests
Version 4.1 by Rudi Marais on 2022/02/08 10:43
Show last authors
| author | version | line-number | content |
|---|---|---|---|
| 1 | {{toc/}} | ||
| 2 | |||
| 3 | = Setup "My Pull Requests" = | ||
| 4 | |||
| 5 | This allows you to see pull requests under a repository on your dashboard | ||
| 6 | |||
| 7 | 1. Go to: [[https:~~/~~/dev.azure.com/ebsphere/>>https://dev.azure.com/ebsphere/]] | ||
| 8 | 1. Click on "My Pull Requests" | ||
| 9 | 1. Click on "Customize View" | ||
| 10 | 1. Click on "Assigned to my teams" | ||
| 11 | 1. Under Assigned to put the review team ie: migration-code-review | ||
| 12 | |||
| 13 | Sample screenshot | ||
| 14 | |||
| 15 | [[image:1643888832245-695.png]] | ||
| 16 | |||
| 17 | |||
| 18 | |||
| 19 | = Viewing Pull Requests = | ||
| 20 | |||
| 21 | You can view all pull requests across all repositories by going to the "My Pull Requests" landing page: [[https:~~/~~/dev.azure.com/ebsphere/_pulls>>https://dev.azure.com/ebsphere/_pulls]] | ||
| 22 | |||
| 23 | |||
| 24 | = Policies = | ||
| 25 | |||
| 26 | |||
| 27 | 1. There is a group setup for each repository that deals with code review | ||
| 28 | 1. Only members in this group can approve a pull request and the default required reviewer is 1 | ||
| 29 | 1. You cannot approve your own pull request | ||
| 30 | 1. You cannot approve someone elses pull request if you where last to make changes to the branch | ||
| 31 | 1. When a new change has been pushed it will reset the approved viewer count | ||
| 32 | 1. If any outstanding issues/comments are on a pull request it will block the pull request until resolved | ||
| 33 | 1. The merge back to master is restricted to a squash merge, this prevents polluting the history see [[Merge strategies and squash merge - Azure Repos | Microsoft Docs>>url:https://docs.microsoft.com/en-us/azure/devops/repos/git/merging-with-squash?view=azure-devops]] | ||
| 34 | |||
| 35 | |||
| 36 |